Validate input for a manually entered bridge

Feedback Tor Browser Alpha Feedback
1

Tor Browser

Tor Browser Alpha 11.5a13, 64bit

Installation

Tor Browser installed by torbrowser-install-win64-11.5a13_en-US.exe

Device and platform

PC, Windows 10 Home (21H2), 64bit, German

Steps to reproduce

  1. Install browser and start it
  2. hamburger menu → Connection → click button “Add a Bridge Manually…”, type in nonsense and leave with OK

grafik

  1. Close and restart browser
  2. hamburger menu → Connection. There’s an enabled bridge now

grafik

and in the logs there are two warnings

[WARN] Error parsing Bridge address '489fvnvk49fgh34kruvnvf'
[WARN] Controller gave us config lines that didn't validate: Bridge line did not parse. See logs for details.

The browser accepted the input, created a bridge and then tells me that there’s something wrong with it :wink:

3 Likes
2

Thanks @tobrop, this is an excellent suggestion and is certainly on our radar. Moving the options to configure a bridge behind modal windows was the first step, and implementing some form of validation will come next.

You can follow the wider issue about Tor Browser quietly accepting bad configuration options within connection settings here:

3

Actually, we do not validate bridge lines by design to allow adding new PTs without modifying Tor Browser code.

But we could check that at least the user is inserting an IP address with a port.